220 13630 <ad5b9993-452a-4e64-81f5-257f8cbad01c@isocpp.org> article
Path: news.gmane.org!not-for-mail
From: Ivo <ivo.doko@gmail.com>
Newsgroups: gmane.comp.lang.c++.isocpp.proposals
Subject: Re: Adding xorshift* / xorshift+ PRNGs to the set of
 standard PRNG engines in <random>
Date: Fri, 3 Oct 2014 11:51:27 -0700 (PDT)
Lines: 84
Approved: news@gmane.org
Message-ID: <ad5b9993-452a-4e64-81f5-257f8cbad01c@isocpp.org>
References: <207ead8a-a291-4583-9480-dc8838925ac4@isocpp.org>
Reply-To: std-proposals@isocpp.org
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_809_1817714448.1412362287386"
X-Trace: ger.gmane.org 1412362296 29796 80.91.229.3 (3 Oct 2014 18:51:36 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 3 Oct 2014 18:51:36 +0000 (UTC)
To: std-proposals@isocpp.org
Original-X-From: std-proposals+bncBDYYZA4JQ4OBBL7AXOQQKGQEZZQBP3Q@isocpp.org Fri Oct 03 20:51:30 2014
Return-path: <std-proposals+bncBDYYZA4JQ4OBBL7AXOQQKGQEZZQBP3Q@isocpp.org>
Envelope-to: gclcip-std-proposals@m.gmane.org
Original-Received: from mail-oi0-f71.google.com ([209.85.218.71])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <std-proposals+bncBDYYZA4JQ4OBBL7AXOQQKGQEZZQBP3Q@isocpp.org>)
	id 1Xa7wv-0003Zm-GL
	for gclcip-std-proposals@m.gmane.org; Fri, 03 Oct 2014 20:51:29 +0200
Original-Received: by mail-oi0-f71.google.com with SMTP id v63sf11378121oia.10
        for <gclcip-std-proposals@m.gmane.org>; Fri, 03 Oct 2014 11:51:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:message-id:in-reply-to:references:subject:mime-version
         :x-original-sender:reply-to:precedence:mailing-list:list-id
         :list-post:list-help:list-archive:list-subscribe:list-unsubscribe
         :content-type;
        bh=wsB1A/H4Ewdaey8XcuEg50YW+fJZcheFEUwpt8kfRm4=;
        b=D7SBVva+5mo0qw9jF+xtrRefew0uNL0wbq1vNXQYOl94CyBY/c4o6gyN1m9g0zOBqg
         HpybLspOZ4P4mvFS8qCCzDt8izOEmZTyjXnPM22tzTzED0QOdmFaHCiBXVVQ4U2mKLHZ
         02gmea6aFcuGOYP7NMbwyjd/kmYsEZwq9QeoTsYzYOvc+Ofn165GDJINeKj5JhUqxhAt
         yz8+d97T5LP1dBQ0IdDlDZzwFyvSHAvXnvDmFA/zFDNIlCCpPvgLor2xpcbxxSNKuQwA
         NJODzqt5111It8yFziWUCHYmDhWKsAxOrdA0RdYm7GdHCUNr39eeNtymBlQJ/F64WJax
         13gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:date:from:to:message-id:in-reply-to:references
         :subject:mime-version:x-original-sender:reply-to:precedence
         :mailing-list:list-id:list-post:list-help:list-archive
         :list-subscribe:list-unsubscribe:content-type;
        bh=wsB1A/H4Ewdaey8XcuEg50YW+fJZcheFEUwpt8kfRm4=;
        b=ZkijWXMZoz/b2DVIwXP5yjkgCYQe8Byip6o//2mmZS0BjVLp2bqPqKM0Zqssxxm7gC
         9r6rso+QtjW4/EQkdq04pEyDpl9eYEot5YdZhbwu5lIQ+8t02QDlYdm/s46HZ3mgABp7
         ebB0fWmEFQvtBOhjneI3ypXb8i/iFdEhNPR3wF9cQMqior4An2h1ZlaRvU3iU1fGHyVL
         xziHcMlOnvOKt0xXB6gGSxn7SQXVULcODaYIpE5BndbFY7U5SS5D9x0G4o0ra4YyBnUu
         PHEUNz8ewsT8vue8FFDNHc7OaLhdbaXTyqw3euj8yjo5N0VAFEsSRgO+FnDK9i89YU3c
         MqQQ==
X-Gm-Message-State: ALoCoQmM56GaZmYxHyBSdzR5vI0tAFcuEqNC2GNkcAQ2CDOEuNyycOgCgiMyXR37FzcJMOlsKxVx
X-Received: by 10.182.18.8 with SMTP id s8mr5940050obd.21.1412362288363;
        Fri, 03 Oct 2014 11:51:28 -0700 (PDT)
X-BeenThere: std-proposals@isocpp.org
Original-Received: by 10.140.43.198 with SMTP id e64ls1354219qga.23.gmail; Fri, 03 Oct
 2014 11:51:27 -0700 (PDT)
X-Received: by 10.140.80.210 with SMTP id c76mr18482qgd.18.1412362287862;
        Fri, 03 Oct 2014 11:51:27 -0700 (PDT)
In-Reply-To: <207ead8a-a291-4583-9480-dc8838925ac4@isocpp.org>
X-Original-Sender: ivo.doko@gmail.com
Precedence: list
Mailing-list: list std-proposals@isocpp.org; contact std-proposals+owners@isocpp.org
List-ID: <std-proposals.isocpp.org>
X-Google-Group-Id: 399137483710
List-Post: <http://groups.google.com/a/isocpp.org/group/std-proposals/post>, <mailto:std-proposals@isocpp.org>
List-Help: <http://support.google.com/a/isocpp.org/bin/topic.py?topic=25838>, <mailto:std-proposals+help@isocpp.org>
List-Archive: <http://groups.google.com/a/isocpp.org/group/std-proposals/>
List-Subscribe: <http://groups.google.com/a/isocpp.org/group/std-proposals/subscribe>,
 <mailto:std-proposals+subscribe@isocpp.org>
List-Unsubscribe: <mailto:googlegroups-manage+399137483710+unsubscribe@googlegroups.com>,
 <http://groups.google.com/a/isocpp.org/group/std-proposals/subscribe>
Xref: news.gmane.org gmane.comp.lang.c++.isocpp.proposals:13630
Archived-At: <http://permalink.gmane.org/gmane.comp.lang.c++.isocpp.proposals/13630>

------=_Part_809_1817714448.1412362287386
Content-Type: text/plain; charset=UTF-8

I have discovered a mistake in a comment in the file xorshift.h (in the 
implementation I have provided). Instead of

* @tparam n  The state size (== n * 8 bytes).

It should be

* @tparam n  The state size (== n * sizeof(UIntType) bytes).

Since all the reference generators use only 64-bit unsigned integers, I 
have mistakenly generalised.

-- 

--- 
You received this message because you are subscribed to the Google Groups "ISO C++ Standard - Future Proposals" group.
To unsubscribe from this group and stop receiving emails from it, send an email to std-proposals+unsubscribe@isocpp.org.
To post to this group, send email to std-proposals@isocpp.org.
Visit this group at http://groups.google.com/a/isocpp.org/group/std-proposals/.

------=_Part_809_1817714448.1412362287386
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I have discovered a mistake in a comment in the file xorsh=
ift.h (in the implementation I have provided). Instead of<br><br><div class=
=3D"prettyprint" style=3D"background-color: rgb(250, 250, 250); border-colo=
r: rgb(187, 187, 187); border-style: solid; border-width: 1px; word-wrap: b=
reak-word;"><code class=3D"prettyprint"><div class=3D"subprettyprint"><span=
 style=3D"color: #660;" class=3D"styled-by-prettify">*</span><span style=3D=
"color: #000;" class=3D"styled-by-prettify"> </span><span style=3D"color: #=
066;" class=3D"styled-by-prettify">@tparam</span><span style=3D"color: #000=
;" class=3D"styled-by-prettify"> n &nbsp;</span><span style=3D"color: #606;=
" class=3D"styled-by-prettify">The</span><span style=3D"color: #000;" class=
=3D"styled-by-prettify"> state size </span><span style=3D"color: #660;" cla=
ss=3D"styled-by-prettify">(=3D=3D</span><span style=3D"color: #000;" class=
=3D"styled-by-prettify"> n </span><span style=3D"color: #660;" class=3D"sty=
led-by-prettify">*</span><span style=3D"color: #000;" class=3D"styled-by-pr=
ettify"> </span><span style=3D"color: #066;" class=3D"styled-by-prettify">8=
</span><span style=3D"color: #000;" class=3D"styled-by-prettify"> bytes</sp=
an><span style=3D"color: #660;" class=3D"styled-by-prettify">).</span></div=
></code></div><br>It should be<br><br><div class=3D"prettyprint" style=3D"b=
ackground-color: rgb(250, 250, 250); border-color: rgb(187, 187, 187); bord=
er-style: solid; border-width: 1px; word-wrap: break-word;"><code class=3D"=
prettyprint"><div class=3D"subprettyprint"><span style=3D"color: #660;" cla=
ss=3D"styled-by-prettify">*</span><span style=3D"color: #000;" class=3D"sty=
led-by-prettify"> </span><span style=3D"color: #066;" class=3D"styled-by-pr=
ettify">@tparam</span><span style=3D"color: #000;" class=3D"styled-by-prett=
ify"> n &nbsp;</span><span style=3D"color: #606;" class=3D"styled-by-pretti=
fy">The</span><span style=3D"color: #000;" class=3D"styled-by-prettify"> st=
ate size </span><span style=3D"color: #660;" class=3D"styled-by-prettify">(=
=3D=3D</span><span style=3D"color: #000;" class=3D"styled-by-prettify"> n <=
/span><span style=3D"color: #660;" class=3D"styled-by-prettify">*</span><sp=
an style=3D"color: #000;" class=3D"styled-by-prettify"> </span><span style=
=3D"color: #008;" class=3D"styled-by-prettify">sizeof</span><span style=3D"=
color: #660;" class=3D"styled-by-prettify">(</span><span style=3D"color: #6=
06;" class=3D"styled-by-prettify">UIntType</span><span style=3D"color: #660=
;" class=3D"styled-by-prettify">)</span><span style=3D"color: #000;" class=
=3D"styled-by-prettify"> bytes</span><span style=3D"color: #660;" class=3D"=
styled-by-prettify">).</span></div></code></div><br>Since all the reference=
 generators use only 64-bit unsigned integers, I have mistakenly generalise=
d.<br></div>

<p></p>

-- <br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;ISO C++ Standard - Future Proposals&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:std-proposals+unsubscribe@isocpp.org">std-proposa=
ls+unsubscribe@isocpp.org</a>.<br />
To post to this group, send email to <a href=3D"mailto:std-proposals@isocpp=
..org">std-proposals@isocpp.org</a>.<br />
Visit this group at <a href=3D"http://groups.google.com/a/isocpp.org/group/=
std-proposals/">http://groups.google.com/a/isocpp.org/group/std-proposals/<=
/a>.<br />

------=_Part_809_1817714448.1412362287386--

.